-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assistants API support for Azure OpenAI #72
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
============================================
- Coverage 89.31% 88.47% -0.85%
- Complexity 673 680 +7
============================================
Files 122 122
Lines 1058 1093 +35
Branches 15 19 +4
============================================
+ Hits 945 967 +22
- Misses 84 95 +11
- Partials 29 31 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, take actions on the 10 observations.
src/demo/java/io/github/sashirestela/openai/demo/ChatAzureServiceDemo.java
Show resolved
Hide resolved
src/demo/java/io/github/sashirestela/openai/demo/ChatAzureServiceDemo.java
Show resolved
Hide resolved
@sashirestela fixed all observations and answered some of the questions. ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, take action on the new 7 observations.
src/demo/java/io/github/sashirestela/openai/demo/ChatAzureServiceDemo.java
Outdated
Show resolved
Hide resolved
src/demo/java/io/github/sashirestela/openai/demo/AssistantAzureServiceDemo.java
Outdated
Show resolved
Hide resolved
src/demo/java/io/github/sashirestela/openai/demo/AssistantAzureServiceDemo.java
Outdated
Show resolved
Hide resolved
src/demo/java/io/github/sashirestela/openai/demo/ChatAzureServiceDemo.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sashirestela/openai/SimpleOpenAIAzure.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/sashirestela/openai/SimpleOpenAIAzure.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
This PR addresses issue #73
Ran spotless check.