Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistants API support for Azure OpenAI #72

Merged
merged 20 commits into from
Apr 15, 2024

Conversation

the-gigi
Copy link
Contributor

@the-gigi the-gigi commented Apr 4, 2024

This PR addresses issue #73

  • Implement the Files, Assistants and Threads API endpoints in SimpleOpenAIAzure
  • Update ChatAzureServiceDemo to use deployments that are available to test
  • Create new AssistantAzureService Demo (streaming not supported)
  • Switch to blocking mode for vision (streaming returns 200 response, but with no choices)
  • Improved tests a little
  • Also minor change to rundemo.sh to make it bash3.2 compatible (default on MacOS) - the previous code requires bash 4.0
  • Updated README with Azure OpenAI environment for the demo

Ran spotless check.

❯ mvn spotless:check
[INFO] Scanning for projects...
[INFO]
[INFO] ----------------< io.github.sashirestela:simple-openai >----------------
[INFO] Building simple-openai 2.1.1
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- spotless:2.43.0:check (default-cli) @ simple-openai ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.646 s
[INFO] Finished at: 2024-04-03T20:33:04-07:00
[INFO] ------------------------------------------------------------------------

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 74.07407% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 88.47%. Comparing base (1018152) to head (d315f71).

Files Patch % Lines
.../github/sashirestela/openai/SimpleOpenAIAzure.java 74.07% 11 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #72      +/-   ##
============================================
- Coverage     89.31%   88.47%   -0.85%     
- Complexity      673      680       +7     
============================================
  Files           122      122              
  Lines          1058     1093      +35     
  Branches         15       19       +4     
============================================
+ Hits            945      967      +22     
- Misses           84       95      +11     
- Partials         29       31       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sashirestela sashirestela linked an issue Apr 11, 2024 that may be closed by this pull request
Copy link
Owner

@sashirestela sashirestela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, take actions on the 10 observations.

@the-gigi
Copy link
Contributor Author

@sashirestela fixed all observations and answered some of the questions. ready for re-review

Copy link
Owner

@sashirestela sashirestela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, take action on the new 7 observations.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sashirestela sashirestela merged commit 70307ee into sashirestela:main Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add assistants API support for Azure OpenAI
3 participants