Use winresource instead of winres #44
Conversation
|
|
||
| fn main() { | ||
| if cfg!(target_os = "windows") { | ||
| winres::WindowsResource::new().compile().unwrap(); | ||
| if std::env::var("CARGO_CFG_TARGET_OS").unwrap() == "windows" { |
There was a problem hiding this comment.
What's the behavior difference here?
There was a problem hiding this comment.
To quote winresource documentation:
Please note: Using #[cfg(target_os = "windows")] in build.rs may not work as expected because build.rs is executed on the host. This means that target_os is always equal to host_os when compiling build.rs. E.g. if we use rustc on Linux and want to cross-compile binaries that run on Windows, target_os in build.rs is "linux". However, CARGO_CFG_TARGET_OS should always be defined and contains the actual target operating system, though it can only be checked at runtime of the build script.
There was a problem hiding this comment.
Ah, so that's because build script is always compiled for the host os. Understood, what an easy footgun 😅
|
Thanks! |
winresource is a more updated fork of the winres crate.
winresdoes not work when cross-compiling from Linux, and it did not work for me when using mingw-w64 on a Windows host either. Switching towinresourceand changing the build script to checkCARGO_CFG_TARGET_OSfixed both of these cases.