Enable editing process models in GitHub Codespaces #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See sartography/spiff-arena#2096 (comment) for context
Tested working locally in VS Code DevContainer extension https://code.visualstudio.com/docs/devcontainers/containers
GitHub Codespaces puts each forwarded port on a separate subdomain. That won't work, per the SpiffWorkflow documentation: https://spiff-arena.readthedocs.io/en/latest/DevOps_installation_integration/path_based_routing.html So we introduce an nginx proxy container to implement path-based routing. Unfortunately path-based routing doesn't work with "docker compose up" locally because code in the frontend explicitly assumes that the backend is on a neighboring port if the hostname is "localhost". In spite of that, I'm pushing this change up to see if it fixes the behavior in a GitHub Codespace.
|
Oops, wrong base repo selected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[oops]