Fix issue where response was an embedded json string #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burnettk
approved these changes
Dec 22, 2023
| @@ -66,8 +65,8 @@ def handler(conn: Any, cursor: Any) -> None: | |||
| return self._execute(sql, conn_str, handler) | |||
|
|
|||
| def fetchall(self, sql: str, conn_str: str, values: list) -> ConnectorProxyResponseDict: | |||
| def prep_results(results: dict) -> list: | |||
| return list(map(list, results)) | |||
| def prep_results(results: list) -> list: | |||
There was a problem hiding this comment.
could you possibly add an example input and output or something along those lines to show what this is doing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when calling a stored procedure such as
SELECT get_vendors();via theDoSQLcommand and usingfetch_results: Truethe results would be an embedded json string instead of an object in task data. Fix is to munge the string which represents a row returned from the stored procedure. If the string parsing fails the greater exception handling will return an error.