Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ecto from 3.9 to 3.11 #4053

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Update Ecto from 3.9 to 3.11 #4053

merged 1 commit into from
Jan 12, 2024

Conversation

IvanIvanoff
Copy link
Member

Changes

Updating it requries an update to the Clickhousex driver. The reason is
that Ecto changed how the scheme argument is handled, so now we need to
explicitly convert it from string to atom before passing it to
Mint.HTTP.connect/4

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

Updating it requries an update to the Clickhousex driver. The reason is
that Ecto changed how the scheme argument is handled, so now we need to
explicitly convert it from string to atom before passing it to
Mint.HTTP.connect/4
@IvanIvanoff IvanIvanoff merged commit 515a7f7 into master Jan 12, 2024
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ecto-3.11 branch January 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants