Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle :brod included twice #4050

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Handle :brod included twice #4050

merged 1 commit into from
Jan 9, 2024

Conversation

IvanIvanoff
Copy link
Member

Changes

Brod is in included_application of kaffe. If we just remove it from the
included_applications of sanbase it also gives an error, which is
finally resolved by adding runtime: false to the dependency. It is then
manually started when needed.

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

Brod is in included_application of kaffe. If we just remove it from the
included_applications of sanbase it also gives an error, which is
finally resolved by adding runtime: false to the dependency. It is then
manually started when needed.
@IvanIvanoff IvanIvanoff merged commit a2a43b5 into master Jan 9, 2024
1 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the handle-brod-runtime branch January 9, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant