Add ICP exporter #207
Open
Add ICP exporter #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YordanPavlov
reviewed
Dec 4, 2024
|
|
||
| const transactions = await this.getTransactions(blocks); | ||
|
|
||
| this.lastExportedBlock += blocks.length; |
There was a problem hiding this comment.
Should we assert that we have results for exactly numConcurrentRequests of blocks? Potential problem is the following example. Asking for blocks 1 to 3 and getting results for blocks 1 and 3 only (2 blocks, not 3). This would create weird math of lastExportedBlock being 2, where maybe it should be 3.
YordanPavlov
reviewed
Dec 4, 2024
| export const CONFIRMATIONS = getIntEnvVariable('CONFIRMATIONS', 10); | ||
| export const NODE_URL = process.env.NODE_URL || 'http://localhost:8545/'; | ||
| export const LOOP_INTERVAL_CURRENT_MODE_SEC = getIntEnvVariable('LOOP_INTERVAL_CURRENT_MODE_SEC', 10); | ||
| exports.RPC_USERNAME = process.env.RPC_USERNAME; |
There was a problem hiding this comment.
Mixing two different syntaxes here, most probably this can be unified to:
export RPC_USERNAME = ...
YordanPavlov
reviewed
Dec 4, 2024
| return fetchWithRetry(0); // Start with the first attempt | ||
| } | ||
|
|
||
| async getTransactions(blocks: ICPBlock[]) { |
There was a problem hiding this comment.
This function holds all the domain specific knowledge, it should be unit tested.
There was a problem hiding this comment.
It is a pure function, so you can move it to a separate utils file and test it easily.
YordanPavlov
approved these changes
Dec 4, 2024
Add missing fields to ICP exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.