Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrate): update sanityRequestOptions test #8496

Merged

Conversation

pedrobonamin
Copy link
Contributor

Description

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner February 4, 2025 15:14
@pedrobonamin pedrobonamin requested review from cngonzalez and removed request for a team February 4, 2025 15:14
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 3:21pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 3:21pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 3:21pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 4, 2025 3:21pm
test-next-studio ⬜️ Ignored (Inspect) Feb 4, 2025 3:21pm

@pedrobonamin pedrobonamin requested review from juice49 and removed request for cngonzalez February 4, 2025 15:15
Copy link
Contributor

github-actions bot commented Feb 4, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Component Testing Report Updated Feb 4, 2025 3:26 PM (UTC)

❌ Failed Tests (3) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 2m 0s 4 0 2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 29s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 3s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 2m 24s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚡️ Editor Performance Report

Updated Tue, 04 Feb 2025 15:27:31 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.8 efps (42ms) 21.7 efps (46ms) +4ms (+9.5%)
article (body) 59.5 efps (17ms) 65.4 efps (15ms) -1ms (-8.9%)
article (string inside object) 25.6 efps (39ms) 21.7 efps (46ms) +7ms (+17.9%)
article (string inside array) 22.2 efps (45ms) 20.4 efps (49ms) +4ms (+8.9%)
recipe (name) 50.0 efps (20ms) 50.0 efps (20ms) +0ms (-/-%)
recipe (description) 55.6 efps (18ms) 52.6 efps (19ms) +1ms (+5.6%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.2 efps (52ms) 18.2 efps (55ms) +3ms (+5.8%)
synthetic (string inside object) 19.8 efps (51ms) 18.5 efps (54ms) +4ms (+6.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 42ms 50ms 93ms 306ms 388ms 11.0s
article (body) 17ms 20ms 48ms 214ms 330ms 6.1s
article (string inside object) 39ms 43ms 45ms 290ms 382ms 6.9s
article (string inside array) 45ms 47ms 52ms 176ms 577ms 8.1s
recipe (name) 20ms 22ms 24ms 35ms 0ms 6.6s
recipe (description) 18ms 20ms 25ms 38ms 5ms 4.8s
recipe (instructions) 5ms 7ms 8ms 16ms 0ms 3.1s
synthetic (title) 52ms 55ms 64ms 318ms 813ms 13.1s
synthetic (string inside object) 51ms 58ms 87ms 444ms 979ms 8.7s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 46ms 62ms 68ms 490ms 1093ms 11.4s
article (body) 15ms 20ms 67ms 309ms 470ms 6.0s
article (string inside object) 46ms 48ms 52ms 329ms 545ms 7.8s
article (string inside array) 49ms 53ms 61ms 342ms 824ms 8.3s
recipe (name) 20ms 21ms 23ms 30ms 0ms 6.7s
recipe (description) 19ms 20ms 32ms 37ms 1ms 4.7s
recipe (instructions) 5ms 6ms 7ms 18ms 0ms 3.1s
synthetic (title) 55ms 57ms 62ms 132ms 817ms 18.0s
synthetic (string inside object) 54ms 56ms 62ms 118ms 1066ms 9.1s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin merged commit 1480d54 into feat/content-releases Feb 4, 2025
56 checks passed
@pedrobonamin pedrobonamin deleted the feat/content-releases-update-test branch February 4, 2025 15:33
Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants