Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(releases): UI polish #8492

Merged

Conversation

mariuslundgard
Copy link
Member

Description

  • Fix design implementation of VersionChip
  • Fix a regression in how document title was rendered in document panes

What to review

Testing

Notes for release

@mariuslundgard mariuslundgard requested a review from a team as a code owner February 4, 2025 12:19
@mariuslundgard mariuslundgard requested review from jordanl17 and removed request for a team February 4, 2025 12:19
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 0:22am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 0:22am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 0:22am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 4, 2025 0:22am
test-next-studio ⬜️ Ignored (Inspect) Feb 4, 2025 0:22am

Copy link
Contributor

github-actions bot commented Feb 4, 2025

No changes to documentation

Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great, thank you Marius!

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Component Testing Report Updated Feb 4, 2025 12:26 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 21s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 33s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 4s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 45s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚡️ Editor Performance Report

Updated Tue, 04 Feb 2025 12:32:58 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 21.5 efps (47ms) 20.6 efps (49ms) +2ms (+4.3%)
article (body) 59.5 efps (17ms) 56.2 efps (18ms) +1ms (+6.0%)
article (string inside object) 23.3 efps (43ms) 22.5 efps (45ms) +2ms (+3.5%)
article (string inside array) 20.8 efps (48ms) 20.4 efps (49ms) +1ms (+2.1%)
recipe (name) 50.0 efps (20ms) 47.6 efps (21ms) +1ms (+5.0%)
recipe (description) 58.8 efps (17ms) 52.6 efps (19ms) +2ms (+11.8%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (6ms) +1ms (-/-%)
synthetic (title) 19.2 efps (52ms) 18.5 efps (54ms) +2ms (+3.8%)
synthetic (string inside object) 20.2 efps (50ms) 19.6 efps (51ms) +2ms (+3.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 47ms 70ms 94ms 545ms 1354ms 12.1s
article (body) 17ms 19ms 32ms 140ms 383ms 6.1s
article (string inside object) 43ms 48ms 60ms 78ms 575ms 7.8s
article (string inside array) 48ms 52ms 59ms 82ms 368ms 8.0s
recipe (name) 20ms 21ms 23ms 59ms 0ms 6.7s
recipe (description) 17ms 18ms 22ms 37ms 0ms 4.4s
recipe (instructions) 5ms 7ms 8ms 17ms 0ms 3.1s
synthetic (title) 52ms 53ms 55ms 132ms 440ms 12.3s
synthetic (string inside object) 50ms 53ms 84ms 474ms 592ms 8.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 49ms 63ms 96ms 563ms 1643ms 12.8s
article (body) 18ms 21ms 54ms 209ms 282ms 6.2s
article (string inside object) 45ms 48ms 53ms 243ms 441ms 8.0s
article (string inside array) 49ms 52ms 58ms 183ms 663ms 8.0s
recipe (name) 21ms 22ms 26ms 42ms 0ms 6.8s
recipe (description) 19ms 20ms 21ms 43ms 0ms 4.6s
recipe (instructions) 6ms 8ms 9ms 21ms 0ms 3.1s
synthetic (title) 54ms 59ms 65ms 280ms 912ms 13.6s
synthetic (string inside object) 51ms 56ms 64ms 634ms 1341ms 8.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Marius!

@pedrobonamin pedrobonamin merged commit 84190bf into feat/content-releases Feb 4, 2025
57 checks passed
@pedrobonamin pedrobonamin deleted the refactor/content-releases-ui-polish branch February 4, 2025 13:08
pedrobonamin pushed a commit that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants