Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structure): do not set history inspector height to 0 #8421

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Jan 27, 2025

Description

The getScrollerRef function is called when the element is empty, this changes the height to 0 and it doesn't reset after selecting the tab.
This adds a check to validate that the height is only set if it exists.

What to review

Testing

Notes for release

fixes an issue in which the history will not load if user open the History → Review Changes → History.

@pedrobonamin pedrobonamin requested a review from a team as a code owner January 27, 2025 17:56
@pedrobonamin pedrobonamin requested review from rexxars and removed request for a team January 27, 2025 17:56
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 5:57pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 5:57pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 5:57pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 27, 2025 5:57pm
test-next-studio ⬜️ Ignored (Inspect) Jan 27, 2025 5:57pm

Copy link
Contributor

No changes to documentation

@pedrobonamin pedrobonamin requested review from a team and bjoerge January 27, 2025 17:57
Copy link
Contributor

Component Testing Report Updated Jan 27, 2025 6:03 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 19s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 34s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 4s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Mon, 27 Jan 2025 18:08:54 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.1 efps (42ms) 21.1 efps (48ms) +6ms (+14.5%)
article (body) 59.3 efps (17ms) 63.3 efps (16ms) -1ms (-6.2%)
article (string inside object) 24.4 efps (41ms) 22.2 efps (45ms) +4ms (+9.8%)
article (string inside array) 20.0 efps (50ms) 20.0 efps (50ms) +0ms (-/-%)
recipe (name) 47.6 efps (21ms) 55.6 efps (18ms) -3ms (-14.3%)
recipe (description) 55.6 efps (18ms) 58.8 efps (17ms) -1ms (-5.6%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.5 efps (54ms) 18.9 efps (53ms) -1ms (-1.9%)
synthetic (string inside object) 18.9 efps (53ms) 19.0 efps (53ms) -1ms (-0.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 42ms 63ms 66ms 351ms 675ms 10.7s
article (body) 17ms 20ms 36ms 138ms 88ms 5.6s
article (string inside object) 41ms 44ms 53ms 93ms 392ms 7.2s
article (string inside array) 50ms 52ms 56ms 72ms 220ms 7.3s
recipe (name) 21ms 23ms 26ms 43ms 0ms 7.4s
recipe (description) 18ms 20ms 22ms 35ms 0ms 4.6s
recipe (instructions) 5ms 7ms 7ms 8ms 0ms 3.0s
synthetic (title) 54ms 57ms 70ms 385ms 1173ms 18.4s
synthetic (string inside object) 53ms 55ms 69ms 320ms 524ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 48ms 66ms 78ms 531ms 1105ms 11.8s
article (body) 16ms 19ms 32ms 246ms 334ms 5.8s
article (string inside object) 45ms 48ms 54ms 98ms 226ms 7.3s
article (string inside array) 50ms 53ms 59ms 323ms 292ms 7.9s
recipe (name) 18ms 20ms 23ms 41ms 0ms 7.4s
recipe (description) 17ms 18ms 19ms 30ms 0ms 4.3s
recipe (instructions) 5ms 6ms 7ms 10ms 0ms 3.0s
synthetic (title) 53ms 55ms 61ms 336ms 907ms 13.0s
synthetic (string inside object) 53ms 59ms 73ms 535ms 1412ms 8.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin added this pull request to the merge queue Jan 27, 2025
Merged via the queue into next with commit abb0b2e Jan 27, 2025
57 checks passed
@pedrobonamin pedrobonamin deleted the fix-history-inspector branch January 27, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants