Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade vitest to v3 #8371

Open
wants to merge 2 commits into
base: upgrade-vite-v6
Choose a base branch
from
Open

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jan 22, 2025

Description

(note: builds upon the changes in #8370)

Upgrades vitest to v3

What to review

Does the test pass?

Testing

Tests should pass

Notes for release

n/a – internal

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 5:17pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 5:17pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 5:17pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 5:17pm
test-next-studio ⬜️ Ignored (Inspect) Jan 22, 2025 5:17pm

Copy link

socket-security bot commented Jan 22, 2025

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] 🔁 npm/[email protected] Transitive: filesystem, network, shell, unsafe +94 15.1 MB antfu, oreanno, patak, ...1 more

View full report↗︎

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Component Testing Report Updated Jan 22, 2025 5:19 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 20s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 30s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 1s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 43s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 22, 2025

⚡️ Editor Performance Report

Updated Wed, 22 Jan 2025 17:20:22 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.5 efps (43ms) 22.0 efps (46ms) +3ms (+7.1%)
article (body) 67.3 efps (15ms) 63.3 efps (16ms) +1ms (-/-%)
article (string inside object) 25.0 efps (40ms) 23.8 efps (42ms) +2ms (+5.0%)
article (string inside array) 23.3 efps (43ms) 21.7 efps (46ms) +3ms (+7.0%)
recipe (name) 52.6 efps (19ms) 50.0 efps (20ms) +1ms (+5.3%)
recipe (description) 57.1 efps (18ms) 55.6 efps (18ms) +1ms (+2.9%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.2 efps (52ms) 18.5 efps (54ms) +2ms (+3.8%)
synthetic (string inside object) 20.4 efps (49ms) 18.5 efps (54ms) +5ms (+10.2%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 46ms 87ms 446ms 306ms 11.2s
article (body) 15ms 19ms 33ms 212ms 423ms 5.9s
article (string inside object) 40ms 42ms 45ms 146ms 293ms 7.2s
article (string inside array) 43ms 46ms 53ms 246ms 328ms 7.2s
recipe (name) 19ms 21ms 25ms 41ms 0ms 6.6s
recipe (description) 18ms 19ms 20ms 36ms 0ms 4.5s
recipe (instructions) 5ms 7ms 8ms 21ms 0ms 3.2s
synthetic (title) 52ms 54ms 57ms 67ms 512ms 12.7s
synthetic (string inside object) 49ms 51ms 61ms 319ms 472ms 7.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 46ms 64ms 70ms 386ms 1013ms 11.0s
article (body) 16ms 19ms 25ms 67ms 345ms 5.9s
article (string inside object) 42ms 45ms 52ms 299ms 376ms 7.4s
article (string inside array) 46ms 49ms 58ms 70ms 648ms 7.8s
recipe (name) 20ms 21ms 25ms 40ms 0ms 6.6s
recipe (description) 18ms 20ms 23ms 42ms 0ms 4.8s
recipe (instructions) 5ms 7ms 9ms 19ms 0ms 3.1s
synthetic (title) 54ms 58ms 89ms 335ms 1112ms 12.7s
synthetic (string inside object) 54ms 59ms 69ms 493ms 1369ms 8.8s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants