-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): explicitly exit workers when they're done #8226
base: next
Are you sure you want to change the base?
Conversation
A Node script only exists once all pending handles/requests are completed. It's quite common for dependencies to open various handles and thus prevent the script for naturally exiting. This changes all the scripts which we run inside worker threads to explicitly exit when they're done.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No changes to documentation |
Component Testing Report Updated Jan 9, 2025 2:50 PM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Thu, 09 Jan 2025 14:52:51 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
A Node script only exists once all pending handles/requests are completed. It's quite common for dependencies to open various handles and thus prevent the script for naturally exiting. This changes all the scripts which we run inside worker threads to explicitly exit when they're done.
This impacts the following commands:
schema extract
,manifest extract
,graphql deploy
,documents validate
,schema validate
.This also now unifies the commands so that they all have a
main
function.What to review
schema extract
,manifest extract
,graphql deploy
,documents validate
,schema validate
.Testing
I've tested
schema extract
andmanifest extract
on a custom Studio linked to this version locally. I've not tested the other ones.Notes for release
Fixes a case where the commands
schema extract
,manifest extract
,graphql deploy
,documents validate
orschema validate
would never complete.