Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: useBundleDocuments only invoked when release menu is opened #8205

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

jordanl17
Copy link
Member

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 0:40am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 0:40am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 0:40am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 0:40am
test-next-studio ⬜️ Ignored (Inspect) Jan 9, 2025 0:40am

Copy link
Contributor

github-actions bot commented Jan 7, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Component Testing Report Updated Jan 9, 2025 12:36 AM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 38s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 30s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 2m 18s 17 0 1
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 43s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 7, 2025

⚡️ Editor Performance Report

Updated Thu, 09 Jan 2025 00:38:53 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.8 efps (42ms) 18.2 efps (55ms) +13ms (+31.0%) 🔴
article (body) 50.3 efps (20ms) 48.0 efps (21ms) +1ms (+4.8%)
article (string inside object) 25.3 efps (40ms) 19.2 efps (52ms) +13ms (+31.6%) 🔴
article (string inside array) 22.2 efps (45ms) 17.9 efps (56ms) +11ms (+24.4%) 🔴
recipe (name) 50.0 efps (20ms) 31.3 efps (32ms) +12ms (+60.0%) 🔴
recipe (description) 58.8 efps (17ms) 32.3 efps (31ms) +14ms (+82.4%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 18.7 efps (54ms) 7.8 efps (128ms) +75ms (+139.3%) 🔴
synthetic (string inside object) 18.7 efps (54ms) 8.2 efps (122ms) +68ms (+127.1%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 42ms 48ms 51ms 458ms 317ms 11.0s
article (body) 20ms 22ms 32ms 158ms 213ms 5.5s
article (string inside object) 40ms 42ms 47ms 63ms 138ms 6.9s
article (string inside array) 45ms 48ms 59ms 257ms 388ms 7.4s
recipe (name) 20ms 23ms 28ms 40ms 0ms 7.6s
recipe (description) 17ms 19ms 22ms 30ms 0ms 4.4s
recipe (instructions) 6ms 8ms 9ms 12ms 0ms 3.1s
synthetic (title) 54ms 56ms 66ms 284ms 879ms 12.5s
synthetic (string inside object) 54ms 57ms 69ms 231ms 1180ms 8.7s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 55ms 64ms 91ms 615ms 1653ms 12.9s
article (body) 21ms 24ms 41ms 145ms 367ms 6.0s
article (string inside object) 52ms 58ms 62ms 178ms 584ms 8.0s
article (string inside array) 56ms 61ms 67ms 216ms 824ms 8.4s
recipe (name) 32ms 34ms 36ms 48ms 2ms 8.3s
recipe (description) 31ms 33ms 41ms 95ms 23ms 5.9s
recipe (instructions) 6ms 8ms 9ms 16ms 0ms 3.2s
synthetic (title) 128ms 136ms 162ms 717ms 6034ms 20.0s
synthetic (string inside object) 122ms 125ms 155ms 415ms 5282ms 14.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@jordanl17 jordanl17 force-pushed the corel-310-efficient-overview branch from 94d6a32 to 2e7de0c Compare January 9, 2025 00:26
@jordanl17 jordanl17 marked this pull request as ready for review January 9, 2025 01:12
@jordanl17 jordanl17 requested a review from a team as a code owner January 9, 2025 01:12
@jordanl17 jordanl17 requested review from ricokahler, a team and bjoerge and removed request for a team, ricokahler and bjoerge January 9, 2025 01:12
@jordanl17 jordanl17 merged commit 35011d0 into corel Jan 9, 2025
54 of 55 checks passed
@jordanl17 jordanl17 deleted the corel-310-efficient-overview branch January 9, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant