Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to android 11 #225

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Update to android 11 #225

merged 2 commits into from
Nov 4, 2020

Conversation

NickalasB
Copy link
Contributor

Fixes issue #224 .
This PR changes:
  • Add manifest query to allow camera to launch properly on Android API 30

  • Fix some runtime nullability errors with arrayLists

  • Update README

  • Add ripple to camera button

* Fix some runtime nullability errors with arrayLists

* Update README

* Add ripple to camera button
@sangcomz sangcomz self-requested a review November 4, 2020 13:36
@sangcomz
Copy link
Owner

sangcomz commented Nov 4, 2020

Thank you, PR.

Please change the base branch to develop branch.

@NickalasB NickalasB changed the base branch from master to develop November 4, 2020 16:55
@NickalasB
Copy link
Contributor Author

Thank you, PR.

Please change the base branch to develop branch.

Done

Copy link
Owner

@sangcomz sangcomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangcomz sangcomz merged commit 381f201 into sangcomz:develop Nov 4, 2020
@NickalasB NickalasB deleted the update_to_android_11 branch November 4, 2020 19:11
@sangcomz sangcomz mentioned this pull request Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants