-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Drop support for Python 3.8 #156
Conversation
Reviewer's Guide by SourceryThis PR removes Python 3.8 support from the project by updating type hints to use native syntax available in Python 3.9+ and modernizing dictionary operations. The changes primarily involve updating type annotations throughout the codebase and modifying dictionary merge operations to use the union operator. Updated class diagram for StagedScript classclassDiagram
class StagedScript {
-Namespace args
-list~str~ commands_executed
-Console console
-str current_stage
-bool dry_run
-list~StageDuration~ durations
-bool print_commands
-str script_name
-str script_stem
-bool script_success
-datetime stage_start_time
-set~str~ stages
-set~str~ stages_to_run
-datetime start_time
+__init__(stages: set~str~, console_force_terminal: Optional~bool~ = None, console_log_path: bool = True, print_commands: bool = False)
+parse_args(argv: list~str~) : None
+print_script_execution_summary(extra_sections: Optional~dict~str, str~~ = None) : None
+_current_arg_is_long_flag(args: list~str~) : bool
+_next_arg_is_flag(args: list~str~) : bool
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jmgate - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 180 180
Branches 15 15
=========================================
Hits 180 180 ☔ View full report in Codecov by Sentry. |
* Use type-hinting provided out of the box in 3.9. * Use new dictionary update syntax. * Update the docs and CI accordingly.
dc7f57a
to
a9c8005
Compare
@william76, @GhostofGoes, @jcox10, anyone care to review and approve? |
LGTM |
LGTM |
Type: Task
Description
Related Issues/PRs
Motivation
The Python community no longer supports 3.8.
Summary by Sourcery
Drop support for Python 3.8 and update the codebase to utilize Python 3.9 features, including new type hinting syntax and dictionary update syntax. Update documentation and CI configuration to reflect these changes.
Enhancements:
Build:
CI:
Documentation: