Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include fmt/ranges.h in Ioss_Decomposition.C, Ioss_ParallelUtils.h (fmt-11) #477

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Aug 3, 2024

fmt v11 (release notes) "moved range and iterator overloads of fmt::join to fmt/ranges.h, next to other overloads."

This means the fmt::join in Ioss_Decompoition.C is not found:

method, fmt::join(Ioss::valid_decomp_methods(), ", "));

This PR adds the necessary fmt/ranges.h includes in that and one other place (behind a DEBUG define).

A possible other location that needs adapting (but I was unable to verify) is

This change should not have negative effects for older versions of fmt.

@gsjaardema gsjaardema merged commit 424bd6a into sandialabs:master Aug 5, 2024
44 checks passed
@wdconinc wdconinc deleted the patch-1 branch August 5, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants