IOSS: Move transform factory from Iotr to Ioss #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spyridon97 Does this look more usable to you. |
spyridon97
approved these changes
Feb 13, 2024
Yeah, that's way better. Also since we are here, can i point you to some fixes, that i had to do for IOSS in the ioss/for/vtk branch that we have? Or do you want me to create a PR for them? |
|
PR if not too much trouble; otherwise you can send them to me.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the Iotr::Factory to Ioss::TransformFactory to make it easier/clearer for clients on how to create and work with transforms. No longer need to be concerned with the transform/ subdirectory.