TextMesh: Enable block membership capability for sidesets and sideblocks #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsjaardema
reviewed
Feb 2, 2024
| { | ||
| int64_t count = 0; | ||
|
|
||
| const SidesetData *sideset = m_data.sidesets.get_group_data(id); | ||
| int myProc = m_myProcessor; | ||
| if (nullptr != sideset) { | ||
| for (const std::pair<int64_t, int> &elemSidePair : sideset->data) { | ||
| int64_t elemId = elemSidePair.first; | ||
| for (const std::pair<EntityId, int> &elemSidePair : sideset->data) { |
There was a problem hiding this comment.
This might be better as const auto &elemSidePair
gsjaardema
reviewed
Feb 2, 2024
| int64_t count = 0; | ||
| const std::set<int64_t> &myNodes = m_data.nodes_on_proc(m_myProcessor); | ||
| int64_t count = 0; | ||
| const std::set<EntityId> &myNodes = m_data.nodes_on_proc(m_myProcessor); |
There was a problem hiding this comment.
Maybe another const auto &myNodes
gsjaardema
reviewed
Feb 2, 2024
| int64_t elemId = elemSidePair.first; | ||
| int side = elemSidePair.second; | ||
| auto iter = std::find(m_data.elementDataVec.begin(), m_data.elementDataVec.end(), elemId); | ||
| for (const std::pair<EntityId, int> &elemSidePair : sideset->data) { |
There was a problem hiding this comment.
Maybe another const auto &elemSidePair or even a structured binding...
for (const auto [elemId, side] : sideset->data (or whatever correct syntax is)
gsjaardema
reviewed
Feb 2, 2024
| for (const std::pair<int64_t, int> &elemSidePair : sideset->data) { | ||
| int64_t elemId = elemSidePair.first; | ||
| auto iter = std::find(m_data.elementDataVec.begin(), m_data.elementDataVec.end(), elemId); | ||
| for (const std::pair<EntityId, int> &elemSidePair : sideset->data) { |
There was a problem hiding this comment.
const auto &elemSidePair or structured binding, but don't use .seconds, so may get unused variable warning...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagated consistent EntityId (int64_t) through code
Added unit tests for various forms of sideset/sideblock creation