IOSS: Address static analyzer suggestions

sandialabs · Jan 17, 2024 · d946b06 · d946b06
1 parent 69b1454
commit d946b06
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/packages/seacas/libraries/ioss/src/Ioss_Glob.h b/packages/seacas/libraries/ioss/src/Ioss_Glob.h
@@ -189,7 +189,7 @@ namespace Ioss::glob {
       return state_pos;
     }
 
-    size_t fail_state_;
+    size_t fail_state_{0};
 
   private:
     std::tuple<bool, size_t> ExecAux(const String<charT> &str, bool comp_end = true) const
@@ -207,7 +207,7 @@ namespace Ioss::glob {
       // the string
       if (comp_end) {
         if ((state_pos == match_state_) && (str_pos == str.length())) {
-          return {state_pos == match_state_, str_pos};
+          return {true, str_pos};
         }
 
         return {false, str_pos};
@@ -776,13 +776,6 @@ namespace Ioss::glob {
       c_ = str_[++pos_];
     }
 
-    inline bool IsSpecialChar(charT c)
-    {
-      bool b = c == '?' || c == '*' || c == '+' || c == '(' || c == ')' || c == '[' || c == ']' ||
-               c == '|' || c == '!' || c == '@' || c == '\\';
-      return b;
-    }
-
     String<charT> str_;
     size_t        pos_{0};
     charT         c_;