Resolve Recurring Test Hanging #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insertinterestingnamehere
force-pushed
the
hang
branch
from
ab7fd99 to
bd20fd0
Compare
insertinterestingnamehere
force-pushed
the
hang
branch
from
bd20fd0 to
f1dec98
Compare
…the tests and extremely unlikely to work correctly.
insertinterestingnamehere
force-pushed
the
hang
branch
from
47e05f0 to
6443be0
Compare
insertinterestingnamehere
force-pushed
the
hang
branch
from
6443be0 to
d86672d
Compare
In particular: - Increase the default timeout. - Avoid overflowing the number of nanoseconds when adding in the timeout. - Increase the timeout for io threads. - Appropriately handle the case where spurious wakeups happen in pthread_cond_timedwait. Pthreads allows spurious wakeups for this function in its spec. It's unclear if/how much this happens in practice. - Use CLOCK_MONOTONIC instead of gettimeofday as it's more reliable for this use-case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, currently resolving various minor issues around the suspect code. Hopefully one of them resolves it, but thus far they just seem to be mitigations.