-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving QuadratureRule over to an equinox.Module and patched up a few … #96
Conversation
…tests that was using the old QuadratureRule.len method. Now using a __len__ method in QuadratureRule so we can use the python built-in len method.
@btalamini You suggested splitting up PR #87 since @ralberd was seeing some performance regressions from that initial stab I took which likely changed too much too fast. This PR does something simple. Add @ralberd I ran that hole array problem you sent me ~10 times for each implementation and so no real difference. Also, I left the current constructors in place so it didn't touch every file under the sun. With the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 76.40% 76.42% +0.02%
==========================================
Files 61 61
Lines 5051 5056 +5
==========================================
+ Hits 3859 3864 +5
Misses 1192 1192 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really useful! Thanks, Craig!
If it's ok with y'all, I can tag the main branch prior to merging this as say "v0.0.1" or "pre-equinox" so if we need to easily revert to pre-equinox stuff it should be fairly straightforward |
That's a good suggestion. Go for it. |
…tests that was using the old QuadratureRule.len method. Now using a len method in QuadratureRule so we can use the python built-in len method.