Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sofast command line interface #94

Merged
merged 10 commits into from
Apr 26, 2024
Merged

Fix Sofast command line interface #94

merged 10 commits into from
Apr 26, 2024

Conversation

braden6521
Copy link
Collaborator

  • Fixed the SofastCommandLine interface to work after changes to the SystemSofastFixed class.
  • Renamed the file (gitlab makes it look like the old file was deleted and this was newly created, but it was a rename operation.
  • Made the collection of functions a class
  • Still open to changing the architecture sometime, maybe this will provide a better starting point than before.

@braden6521 braden6521 self-assigned this Apr 25, 2024
@braden6521 braden6521 requested a review from bbean23 April 25, 2024 00:20
e10harvey
e10harvey approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@e10harvey e10harvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braden6521 braden6521 merged commit 5a2276d into sandialabs:develop Apr 26, 2024
4 checks passed
@braden6521 braden6521 deleted the fix_sofast_cli branch April 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e10harvey e10harvey e10harvey approved these changes

@bbean23 bbean23 Awaiting requested review from bbean23

Assignees

@braden6521 braden6521

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braden6521 @e10harvey