Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example solar field #90

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix example solar field #90

merged 1 commit into from
Apr 24, 2024

Conversation

e10harvey
Copy link
Collaborator

@e10harvey e10harvey commented Apr 18, 2024 •
edited
Loading

Fixes #51.
Fixes #52.

@e10harvey e10harvey requested a review from braden6521 April 18, 2024 22:31
bbean23
bbean23 previously approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@bbean23 bbean23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

bbean23
bbean23 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@bbean23 bbean23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really should have noticed that you were running pytest twice. Thanks for catching this!

@e10harvey e10harvey merged commit cb27126 into sandialabs:develop Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbean23 bbean23 bbean23 approved these changes

@braden6521 braden6521 Awaiting requested review from braden6521

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e10harvey @bbean23