Remove MemoryMonitor.py and test #56
Conversation
bbean23
force-pushed
the
54-testmemorymonitor-test_large_memory_usage-unit-test-failing
branch
from
b15dce8 to
ff10235
Compare
|
closes #54 |
There was a problem hiding this comment.
@bbean23, thank you for these changes. In general, everything looks great. I do not understand what's causing the bug and need to before attempting to review a fix.
Do you have time to determine the cause of the bug with me today?
Should the test be disabled until the bug is resolved so that others can proceed with their PRs?
|
@e10harvey's reasoning makes sense. Understanding the problem well before fixing makes sense to me. I'm on board with skipping in the meantime. |
…e collection issues
…uld probably be with a third party tool like "top"
bbean23
force-pushed
the
54-testmemorymonitor-test_large_memory_usage-unit-test-failing
branch
from
ff10235 to
119cadd
Compare
|
As determined during our call today, the MemoryMonitor class has been removed, to be replaced with a third party tool like "top" on an as-needed basis. @e10harvey @braden6521 would one of you mind approving? Thanks! |
bbean23
dismissed
e10harvey’s stale review
talked in person, resolved w/ "removal" instead of change
e10harvey
changed the title
This has somehow fixed #54. I'm not entirely sure what the issue was. My guess is that this fixes it because this reduces the possible interaction surface area between the garbage collector and the multiprocessing queue.