Sofast Calibrations use Logtools #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
braden6521
commented
Mar 20, 2024
•
braden6521
commented
- Migrated all print statements in Deflectometry/Sofast calibration/processing routines to use lot_tools.
- Where appropriate, some reformatting to make code more readable.
…imented yet. Resolving merge conflicts.
Fixed merge conflicts 2
Fixing merge conflicts with CalibrationDispalyShape
Fixing merge conflict in example_calibrate_screen_shape
Fixed merge conflict with example-calibration-screen-shape
braden6521
force-pushed
the
sofast_cal_logtools
branch
from
41e993d to
3a27211
Compare
braden6521
changed the title
bbean23
approved these changes
Mar 21, 2024
| ft.create_directories_if_necessary(save_path) | ||
|
|
||
| # Set up logger | ||
| lt.logger(join(save_path, 'log.txt'), lt.log.INFO) |
There was a problem hiding this comment.
Nice, thanks for moving this to here!
| @@ -190,19 +195,19 @@ def bundle_adjustment_sparsity( | |||
| """ | |||
| m = camera_indices.size * 2 # num observed points (x and y) | |||
| n = n_cameras * 6 + n_points * 3 # Nvars | |||
| A = lil_matrix((m, n), dtype=int) # Num xy points x num vars | |||
| jac_sparsity = lil_matrix((m, n), dtype=int) # Num xy points x num vars | |||
There was a problem hiding this comment.
chef's kiss of useful variable names 😚🤌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.