Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: Added format.yml, fixed pep8 violations #34

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

e10harvey
Copy link
Collaborator

No description provided.

@e10harvey e10harvey requested a review from bbean23 March 19, 2024 21:14
@e10harvey e10harvey requested a review from braden6521 March 20, 2024 14:15
@e10harvey
Copy link
Collaborator Author

Reviewers: Please do no worry about reviewing the changes in 6823cc8 as they are all formatting changes.

@braden6521
Copy link
Collaborator

Was this the CI check that we were going to add suggestions from Ben in a settings file? Or would this go somewhere else?

For reference:
max_line_length = 120
ignore = E224,E226,E721,E731

@e10harvey
Copy link
Collaborator Author

Was this the CI check that we were going to add suggestions from Ben in a settings file? Or would this go somewhere else?

For reference: max_line_length = 120 ignore = E224,E226,E721,E731

That is correct. I added the line length suggestion via 0b97988 but am not sure how to add the equivalent of ignore = E224,E226,E721,E731. Hopefully that is acceptable or perhaps we can team up on adding ignore = E224,E226,E721,E731.

Copy link
Collaborator

@braden6521 braden6521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me then!

@e10harvey e10harvey merged commit 3838295 into sandialabs:develop Mar 20, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants