Sofast fixed cal update #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbean23
previously approved these changes
Dec 11, 2024
| self.figures: list = [] | ||
| self.bg_image: np.ndarray = None | ||
| self.name: str = '' | ||
|
|
There was a problem hiding this comment.
I suggest adding a destructor method that closes all the figures held onto by this instance. Maybe consider extending https://github.com/sandialabs/OpenCSP/blob/develop/opencsp/common/lib/render/lib/AbstractPlotHandler.py for this functionality.
| @@ -140,7 +140,7 @@ def __init__( | |||
| self._dot_image_points_indices: Vxy | |||
| self._dot_image_points_indices_x: ndarray | |||
| self._dot_image_points_indices_y: ndarray | |||
| self._dot_points_xyz_mat = np.ndarray((x_max - x_min + 1, y_max - y_min + 1, 3)) * np.nan | |||
| self._dot_points_xyz_mat = np.ndarray((y_max - y_min + 1, x_max - x_min + 1, 3)) * np.nan | |||
There was a problem hiding this comment.
For my own edification, what does multiplying by np.nan accomplish?
There was a problem hiding this comment.
Those matrices get filled in with data as the algorithm finds dots. Since some values may actually be zero, we need some other value to define "no data." NaN seemed appropriate.
| @@ -8,10 +8,15 @@ class ParamsOpticGeometry(hdf5_tools.HDF5_IO_Abstract): | |||
| """Parameter dataclass for processing optic geometry""" | |||
|
|
|||
| perimeter_refine_axial_search_dist: float = 50.0 | |||
| """The length of the search box (along the search direction) to use when finding optic perimeter. Default 50.0""" | |||
There was a problem hiding this comment.
Thank you for adding comments! Are these in units of pixels?
…ed. Only became a problem when dot array was not square.
…es blob assignment data to HDF5.
…nces for Sofast Fixed runs.
…s_optic_singlefacet_geometry to be compatible with necessary changes to process_optic_multifacet_geometry.
…ptic_singlefacet_geometry.
braden6521
force-pushed
the
sofast_fixed_cal_update
branch
from
65c14f0 to
f26cde1
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added more debug options to SofastFixed calibration routine to make diagnosing problems with calibration easier.
Summary of changes
Implementation notes
All updates were debugging-related changes. All unit tests were verified. In one case, a line-color of an output plot changed; this was updated.
Submission checklist
develop, notmainopencsp/test/test_DocStringsExist.pyare verified to include this change or have been updated accordinglydoc/are verified to include this change or have been updated accordinglyAdditional information
(NA)
Please provide any additional information here.