CalibrateDisplayShape visualization improvements #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbean23
approved these changes
Dec 11, 2024
| im_y = np.stack([im_y] * 3, axis=2) | ||
|
|
||
| # Add active pixels as colored pixels | ||
| cm = colormaps.get_cmap('jet') |
There was a problem hiding this comment.
I'm not saying that you need to use this here, I just wanted to let you know about this method:
https://github.com/sandialabs/OpenCSP/blob/develop/opencsp/common/lib/render/Color.py#L212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improved the visualizations in ClaibrateDisplayShape. This makes debugging of Sofast calibrations easier. In some cases, fixed bugs in the way plots were displayed.
Summary of changes
Implementation notes
No study has been performed to completely verify correctness of this function. We are using previous calculations as ground truth for now. These changes don't affect functionality but rather improve users' ability to debug bad inputs.
Submission checklist
develop, notmainopencsp/test/test_DocStringsExist.pyare verified to include this change or have been updated accordinglydoc/are verified to include this change or have been updated accordinglyAdditional information
None