-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
177 RST stubs for ReadTheDocs #178
177 RST stubs for ReadTheDocs #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these changes @bbean23. I left some minor comments below. Please reorganize these rst files to match the directory structore of the code base, like this:
doc/source/library_reference/library/SpotAnalysis -> doc/source/library_reference/common/lib/cv/spot_analysis
. I'd be happy to open a PR into your fork with these changes.
doc/source/library_reference/library/SpotAnalysis/base_classes.rst
Outdated
Show resolved
Hide resolved
doc/source/library_reference/library/SpotAnalysis/base_classes.rst
Outdated
Show resolved
Hide resolved
doc/source/library_reference/library/SpotAnalysis/image_processor.rst
Outdated
Show resolved
Hide resolved
doc/source/library_reference/library/SpotAnalysis/base_classes.rst
Outdated
Show resolved
Hide resolved
opencsp/common/lib/cv/spot_analysis/image_processor/FalseColorImageProcessor.py
Outdated
Show resolved
Hide resolved
doc/source/library_reference/library/SpotAnalysis/image_processor.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I've addressed all your comments. Please note that by "addressed" I sometimes mean "argued against", so please take a look at my comments to see if you agree or not.
doc/source/library_reference/library/SpotAnalysis/base_classes.rst
Outdated
Show resolved
Hide resolved
doc/source/library_reference/library/SpotAnalysis/base_classes.rst
Outdated
Show resolved
Hide resolved
doc/source/library_reference/library/SpotAnalysis/base_classes.rst
Outdated
Show resolved
Hide resolved
doc/source/library_reference/library/SpotAnalysis/image_processor.rst
Outdated
Show resolved
Hide resolved
opencsp/common/lib/cv/spot_analysis/image_processor/FalseColorImageProcessor.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bbean23! I think this can be merged after the headings are made consistent with the rest of the library reference and "also maaaaaybe look at" is reworded to "also see".
…oesn't throw a warning
Co-authored-by: Evan Harvey <[email protected]>
5485cd6
to
0a28c63
Compare
…y meant for internal library use
…SpotAnalysisImagesProcessor)
c1bbf28
to
9bcf584
Compare
@e10harvey Please review again. I made some small changes in order to get the build to pass and documentation to render correctly:
|
Purpose
Please briefly describe the purpose of this pull request. If this fixes a github issue please include
e.g. fixes #22
so that the issue gets closed automatically when this is merged.Summary of changes
Implementation notes
Added AutoSummary to Sphinx for generating class name lists at the top of the documentation files.
Submission checklist
develop
, notmain
opencsp/test/test_DocStringsExist.py
are verified to include this change or have been updated accordinglydoc/
are verified to include this change or have been updated accordinglyAdditional information
none