Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

175 code bug heliostatabstract heliostat tracking drifts #176

Conversation

mhhwang1
Copy link
Collaborator

Purpose

fixes issue 175, bug where heliostat tracking drifts.

Summary of changes

one line code change to HeliostatAbstract and consequently updating the figures.

Implementation notes

Edited HeliostatAbstract and ensured that data was accurate before copying over. (only the axis slightly changed)

Submission checklist

  • [ x] Target branch is develop, not main
  • [x ] Existing tests are updated or new tests were added
  • [x ] opencsp/test/test_DocStringsExist.py are verified to include this change or have been updated accordingly
  • [x ] .rst file(s) under doc/ are verified to include this change or have been updated accordingly

Additional information

@mhhwang1 mhhwang1 added the bug Something isn't working label Oct 23, 2024
@mhhwang1 mhhwang1 requested review from e10harvey and bbean23 October 23, 2024 22:12
@mhhwang1 mhhwang1 self-assigned this Oct 23, 2024
Copy link
Collaborator

@bbean23 bbean23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved!

@e10harvey e10harvey merged commit e765fd3 into sandialabs:develop Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants