-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creating TestMotionBasedCanting #172
Merged
e10harvey
merged 14 commits into
sandialabs:develop
from
mhhwang1:128-create-testmotionbasedcanting
Jan 6, 2025
Merged
creating TestMotionBasedCanting #172
e10harvey
merged 14 commits into
sandialabs:develop
from
mhhwang1:128-create-testmotionbasedcanting
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhhwang1
force-pushed
the
128-create-testmotionbasedcanting
branch
from
October 9, 2024 21:44
595d9dd
to
b6c68b8
Compare
bbean23
previously approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving without review, will review with further changes
…ed HeliostatAbstract.py bug documented by Tristan
mhhwang1
force-pushed
the
128-create-testmotionbasedcanting
branch
from
December 18, 2024 19:21
b6c68b8
to
9c84eee
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
to pull changes of testmotionbasedcanting in before refactoring into testmotionbasedcanting and testcantinganalysis
Summary of changes
created new code testmotionbasedcanting which computes canting angles for heliostats, along with rendering ability and bar plots.
Submission checklist
develop
, notmain
opencsp/test/test_DocStringsExist.py
are verified to include this change or have been updated accordinglydoc/
are verified to include this change or have been updated accordinglyAdditional information
testmotionbasedcanting is still in development, and will later be refactored to be split into two files.