Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating TestMotionBasedCanting #172

Merged

Conversation

mhhwang1
Copy link
Collaborator

@mhhwang1 mhhwang1 commented Oct 9, 2024

Purpose

to pull changes of testmotionbasedcanting in before refactoring into testmotionbasedcanting and testcantinganalysis

Summary of changes

created new code testmotionbasedcanting which computes canting angles for heliostats, along with rendering ability and bar plots.

Submission checklist

  • [x ] Target branch is develop, not main
  • [x ] Existing tests are updated or new tests were added
  • [x ] opencsp/test/test_DocStringsExist.py are verified to include this change or have been updated accordingly
  • [x ] .rst file(s) under doc/ are verified to include this change or have been updated accordingly

Additional information

testmotionbasedcanting is still in development, and will later be refactored to be split into two files.

@mhhwang1 mhhwang1 added the enhancement New feature or request label Oct 9, 2024
@mhhwang1 mhhwang1 requested a review from bbean23 October 9, 2024 21:27
@mhhwang1 mhhwang1 self-assigned this Oct 9, 2024
@mhhwang1 mhhwang1 force-pushed the 128-create-testmotionbasedcanting branch from 595d9dd to b6c68b8 Compare October 9, 2024 21:44
bbean23
bbean23 previously approved these changes Oct 11, 2024
Copy link
Collaborator

@bbean23 bbean23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving without review, will review with further changes

@e10harvey
Copy link
Collaborator

@mhhwang1, @bbean23: Is this ready to be merged?

@mhhwang1 mhhwang1 requested a review from e10harvey December 18, 2024 20:04
@mhhwang1
Copy link
Collaborator Author

@e10harvey: apologize, added another capacity to the code but yes, it's ready to be merged.

@e10harvey e10harvey merged commit adbb05d into sandialabs:develop Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants