Camera IO update #165
Camera IO update #165
Conversation
braden6521
commented
Aug 29, 2024
braden6521
commented
- Fixed ImageAcquisition class to work with new generation of Basler cameras.
- Updated documentation in existing examples
- Created new examples.
There was a problem hiding this comment.
@braden6521: Please add some documentation for the hard coded values. Also, where are the tests for ImAgeAcquisition_DCAM_mono?
| @@ -104,7 +110,9 @@ def instance_matches(self, possible_matches: list[ImageAcquisitionAbstract]) -> | |||
| def get_frame(self) -> np.ndarray: | |||
| # Start frame capture | |||
| self.cap.StartGrabbingMax(1) | |||
| grabResult = self.cap.RetrieveResult(5000, pylon.TimeoutHandling_ThrowException) | |||
| grabResult = self.cap.RetrieveResult( | |||
| int(self.cap.ExposureTimeRaw.Max / 1000 * 1.5), pylon.TimeoutHandling_ThrowException | |||
There was a problem hiding this comment.
Please add quick documentation for 1000 * 1.5
There was a problem hiding this comment.
Good call, it's documented now.
|
@e10harvey, this is another tricky case in terms of unit testing we don't have a good solution for. To test this piece of code, we need a camera and network card physically connected to the computer. In fact, we have no tests for: ImageAcquisition_DCAM_color, ImageAcquisition_DCAM_mono, or ImageAcquisition_MSMF because these all require hardware present. These classes (in addition to all GUIs) are not tested currently. Our solution up to this point has been to have a test for ImageAcquisitionAbstract (in ocmmon/lib/camera/test). Any suggestions are welcome. |
braden6521
force-pushed
the
camera_io_update
branch
from
bfbfb5a to
e6455e9
Compare
Ok, let's get this merged. We can setup a machine with the physical hardware needed to test this. I filed: #174 |
