156 admin code fixes #157
156 admin code fixes #157
Conversation
| @@ -66,8 +66,4 @@ def _opencsp_settings_dirs() -> list[str]: | |||
| opencsp_settings = configparser.ConfigParser(allow_no_value=True) | |||
| opencsp_settings.read(_settings_files) | |||
|
|
|||
| for section in opencsp_settings.sections(): | |||
There was a problem hiding this comment.
Is there a nightly example that causes this for-loop to fail?
There was a problem hiding this comment.
Hmmm? I don't think I understand what you mean. Are you saying I should try triggering a nightly test against this PR?
contrib/scripts/sensitive_strings.py
Outdated
| @@ -109,7 +109,9 @@ def _is_binary_file(self, file_path: str, file_name_ext: str): | |||
| ext = ext.lower() | |||
| if ext == ".ipynb": | |||
| is_binary_file = True | |||
| if self._is_img_ext(ext): | |||
| elif ext == ".h5": | |||
There was a problem hiding this comment.
Is there no corresponding test update?
There was a problem hiding this comment.
There is already a test for HDF5 files, but not for this specific use case.
What this change fixes is I overlooked the possibility of a very large HDF5 file being parse-able as text, and thus taking a very long time for this function to return. Really what I should do here is check for large files and assume anything larger than N kilobytes is a binary file.
There was a problem hiding this comment.
Updated in commit fd5c12d
bbean23
force-pushed
the
156-admin-code-fixes
branch
from
fd5c12d to
1e17ec1
Compare
No description provided.