143 expand linexy constructors and slope information #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braden6521
previously approved these changes
Aug 8, 2024
Comment on lines
259
to
275
| """ | ||
| Get a new instance of this class built from the rho + theta representation of a line. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| rho : float | ||
| The right angle distance between the line and the origin (0,0). For | ||
| images, this will be the top-left corner of the image. | ||
| theta : float | ||
| The angle of the line, in radians, for the standard graphing | ||
| coordinate system. 0 is on the positive x-axis to the right, and the | ||
| angle increases counter-clockwise. | ||
| """ |
There was a problem hiding this comment.
Can you give an example here or clarify. For example, if you had rho=1 and theta=0, would the line pass through x=+1 or x=-1?
There was a problem hiding this comment.
I'm glad you left a comment. I double-checked the method, and realized I had both a bug and a bad definition.
- Changed the definition of theta from "angle of the line" to "angle between the x-axis and the right angle distance vector".
- Removed the cast to an integer, which was causing numeric issues.
- Added unit tests for from_rho_theta() and from_location_angle().
…ifference between positive and negative infinity in the slope
bbean23
force-pushed
the
143-expand-linexy-constructors-and-slope-information
branch
from
fd22626 to
2c42308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.