add copy constructor support to Vxy and Vxyz, add from_list() method … #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bbean23
commented
Aug 6, 2024
bbean23
commented
- add copy constructor support to Vxy and Vxyz
- add from_list() method to Vxy and Vxyz
- add asindex() method to Vxy
e10harvey
requested changes
Aug 6, 2024
| @@ -79,6 +82,14 @@ def y(self): | |||
| def _from_data(cls, data, dtype=float): | |||
| return cls(data, dtype) | |||
|
|
|||
| @classmethod | |||
| def from_list(cls, vals: list["Vxy"]): | |||
There was a problem hiding this comment.
Done! Also added unit tests.
…to Vxy and Vxyz, add asindex() method to Vxy
…hods, fix Vxyz.from_list() method
bbean23
force-pushed
the
146-add-new-constructors-and-as_index-methods-to-vxy-classes
branch
from
2c521cc to
412cc5a
Compare
e10harvey
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.