141 add arrow marker type #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbean23
force-pushed
the
141-add-arrow-marker-type
branch
from
8705b59 to
fc61e64
Compare
bbean23
force-pushed
the
141-add-arrow-marker-type
branch
from
fc61e64 to
95f15bf
Compare
Closed
e10harvey
requested changes
Aug 6, 2024
opencsp/common/lib/render/View3d.py
Outdated
| def draw_xyz(self, xyz, style: rcps.RenderControlPointSeq = None, label: str = None): # An xyz is [x,y,z] | ||
| def draw_xyz( | ||
| self, xyz: tuple[list, list], style: rcps.RenderControlPointSeq = None, label: str = None | ||
| ): # An xyz is [x,y,z] | ||
| """Plots a single point, I think (BGB).""" |
There was a problem hiding this comment.
Please add full doc string here.
There was a problem hiding this comment.
I kinda went overboard, but at least now this method has a full docstring!
f3e689e
e10harvey
approved these changes
Aug 7, 2024
| cls.dir_in = ft.join(path, 'data/input', name.split('test_')[-1]) | ||
| cls.dir_out = ft.join(path, 'data/output', name.split('test_')[-1]) | ||
|
|
||
| ret = super().setUpClass() |
There was a problem hiding this comment.
Thanks for cleaning this up too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.