Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Tower Class and Tests #127

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

mhhwang1
Copy link
Collaborator

Created Tower class, RenderControlTower, and test_TowerOutput to be used for upcoming file TstMotionBasedCanting. Added tests to a new file and should render a simple tower with walls and a target at a specified location on the top of the tower.

@mhhwang1 mhhwang1 added the enhancement New feature or request label Jun 21, 2024
@mhhwang1 mhhwang1 requested review from e10harvey and bbean23 June 21, 2024 16:44
@mhhwang1 mhhwang1 self-assigned this Jun 21, 2024
@e10harvey
Copy link
Collaborator

Thank you, @mhhwang1. @bbean23 will review.

Copy link
Collaborator

@bbean23 bbean23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks great, but I do have a couple of things that could be changed. Please respond to my comments before I approve.

opencsp/common/lib/csp/Tower.py Show resolved Hide resolved
opencsp/common/lib/csp/Tower.py Outdated Show resolved Hide resolved
opencsp/common/lib/csp/Tower.py Outdated Show resolved Hide resolved
opencsp/common/lib/csp/Tower.py Show resolved Hide resolved
opencsp/common/lib/csp/Tower.py Outdated Show resolved Hide resolved
opencsp/common/lib/csp/Tower.py Outdated Show resolved Hide resolved
opencsp/common/lib/render_control/RenderControlTower.py Outdated Show resolved Hide resolved
@e10harvey
Copy link
Collaborator

@mhhwang1: Do you have what you need to finish this?

@mhhwang1 mhhwang1 force-pushed the 126-tower-class-and-tests branch from e74bfc9 to 1e79f8b Compare July 8, 2024 21:24
@mhhwang1 mhhwang1 requested a review from bbean23 July 8, 2024 21:32
Copy link
Collaborator

@bbean23 bbean23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@e10harvey e10harvey merged commit 19cfad1 into sandialabs:develop Jul 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants