Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99 hotspot peak value computation e aj #100

Merged

Conversation

bbean23
Copy link
Collaborator

@bbean23 bbean23 commented Apr 30, 2024

to be done after #97

@bbean23 bbean23 added the enhancement New feature or request label Apr 30, 2024
@bbean23 bbean23 self-assigned this Apr 30, 2024
@bbean23 bbean23 linked an issue May 1, 2024 that may be closed by this pull request
@bbean23 bbean23 force-pushed the 99-hotspot-peak-value-computation-e-aj branch from dc63642 to cbcbe4e Compare May 1, 2024 21:39
@bbean23 bbean23 force-pushed the 99-hotspot-peak-value-computation-e-aj branch from 1657d32 to 3a3a429 Compare June 3, 2024 23:16
@bbean23 bbean23 requested review from e10harvey and braden6521 June 4, 2024 17:24
@bbean23 bbean23 marked this pull request as ready for review June 4, 2024 17:24
import opencsp.common.lib.render_control.RenderControlPointSeq as rcps


class HotspotAnnotation(PointAnnotations):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing doc-string?

import opencsp.common.lib.cv.fiducials.PointFiducials as pf


class PointAnnotations(pf.PointFiducials, AbstractAnnotations):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@bbean23 bbean23 merged commit 2688800 into sandialabs:develop Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hotspot peak value computation [e, aj]
2 participants