Apply suggestions from code review

Co-authored-by: Evan Harvey <[email protected]>
sandialabs · Nov 1, 2024 · 4337f11 · 4337f11
1 parent 0b70654
commit 4337f11
Showing 1 changed file with 36 additions and 36 deletions.
diff --git a/opencsp/common/lib/cv/SpotAnalysis.py b/opencsp/common/lib/cv/SpotAnalysis.py
@@ -58,62 +58,62 @@ class SpotAnalysis(Iterator[tuple[SpotAnalysisOperable]]):
         1. BCS target location (:py:class:`.BcsLocatorImageProcessor`)
         2. Square target location (TargetBoardLocatorImageProcessor)
         3. NULL image subtraction (:py:class:`.NullImageSubtractionImageProcessor`)
-        4. Ambient and gradient light subtraction (TODO)
-        5. Lens correction (TODO)
-        6. Intensity per pixel generation (TODO)
-        7. Centroid calculation (a-h) (TODO)
-        8. FWHM analysis (a,b,d,e,j) (TODO)
-        9. Astigmatism identification (a-e,j) (TODO)
-        10. Automatic beam identification (b) (TODO)
+        4. Ambient and gradient light subtraction (NOT IMPLEMENTED YET)
+        5. Lens correction (NOT IMPLEMENTED YET)
+        6. Intensity per pixel generation (NOT IMPLEMENTED YET)
+        7. Centroid calculation (a-h) (NOT IMPLEMENTED YET)
+        8. FWHM analysis (a,b,d,e,j) (NOT IMPLEMENTED YET)
+        9. Astigmatism identification (a-e,j) (NOT IMPLEMENTED YET)
+        10. Automatic beam identification (b) (NOT IMPLEMENTED YET)
         11. Video-to-frame extraction (f,g) (:py:class:`.ImagesStream`)
-        12. Video streaming (f,g) (TODO)
-        13. Networked image collection (b) (TODO)
-        14. Color-aware image subtraction (c,d,e,h) (TODO)
-        15. Color-aware light subtraction (c,d,e,h) (TODO)
-        16. Time series analysis (f,g) (TODO)
-        17. Laser placement and pointing angle as image metadata (e,h) (TODO)
-        18. Laser placement and pointing angle as separate input (e,h) (TODO)
-        19. Earth mover's metric (i) (TODO)
-        20. Multi-image comparison (f,g,i) (TODO)
-        21. Intensity-to-power mapping (a,d,i,j) (TODO)
+        12. Video streaming (f,g) (NOT IMPLEMENTED YET)
+        13. Networked image collection (b) (NOT IMPLEMENTED YET)
+        14. Color-aware image subtraction (c,d,e,h) (NOT IMPLEMENTED YET)
+        15. Color-aware light subtraction (c,d,e,h) (NOT IMPLEMENTED YET)
+        16. Time series analysis (f,g) (NOT IMPLEMENTED YET)
+        17. Laser placement and pointing angle as image metadata (e,h) (NOT IMPLEMENTED YET)
+        18. Laser placement and pointing angle as separate input (e,h) (NOT IMPLEMENTED YET)
+        19. Earth mover's metric (i) (NOT IMPLEMENTED YET)
+        20. Multi-image comparison (f,g,i) (NOT IMPLEMENTED YET)
+        21. Intensity-to-power mapping (a,d,i,j) (NOT IMPLEMENTED YET)
         22. Noise smoothing (:py:class:`.ConvolutionImageProcessor`)
-        23. Noise removal and quanitification (TODO)
+        23. Noise removal and quanitification (NOT IMPLEMENTED YET)
         24. Multi-image averaging over time (a-e,h-j) (:py:class:`.AverageByGroupImageProcessor`)
-        25. Fiducial identification (e,18,21,23,24) (TODO)
+        25. Fiducial identification (e,18,21,23,24) (NOT IMPLEMENTED YET)
         26. Screen/camera plane homography (TargetBoardLocatorImageProcessor)
         27. Self-PnP and stabilization (:py:class:`.StabilizationImageProcessor`)
-        28. Annotate power envelopes (TODO)
+        28. Annotate power envelopes (NOT IMPLEMENTED YET)
         29. Orthorectify wrt. target (TargetBoardLocatorImageProcessor)
-        30. Orthorectify wrt. beam (TODO)
-        31. Spot radius in mrad, at angle Beta relative to centroid (TODO)
-        32. Spot radius in mrad, at a half angle relative to the heliostat location (TODO)
-        33. Beam radius in mrad, at angle Beta relative to centroid (TODO)
-        34. Beam radius in mrad, at a half angle relative to the heliostat location (TODO)
+        30. Orthorectify wrt. beam (NOT IMPLEMENTED YET)
+        31. Spot radius in mrad, at angle Beta relative to centroid (NOT IMPLEMENTED YET)
+        32. Spot radius in mrad, at a half angle relative to the heliostat location (NOT IMPLEMENTED YET)
+        33. Beam radius in mrad, at angle Beta relative to centroid (NOT IMPLEMENTED YET)
+        34. Beam radius in mrad, at a half angle relative to the heliostat location (NOT IMPLEMENTED YET)
         35. Cropping (:py:class:`.CroppingImageProcessor`)
         36. Over and under exposure detection (:py:class:`.ExposureDetectionImageProcessor`)
-        37. Tagging images as NULL images (TODO)
+        37. Tagging images as NULL images (NOT IMPLEMENTED YET)
         38. Filters (gaussian, box, etc) (:py:class:`.ConvoluationImageProcessor`)
         39. Peak value pixel identification (:py:class:`.HotspotImageProcessor`)
         40. Logorithmic scaling (:py:class:`.LogScaleImageProcessor`)
         41. False color visualization (:py:class:`.FalseColorImageProcessor`)
-        42. Over/under exposure visualization (TODO)
+        42. Over/under exposure visualization (NOT IMPLEMENTED YET)
         43. Image fill/inpainting (:py:class:`.InpaintImageProcessor`)
 
     The inputs to support these features include:
         - primary image or images (:py:meth:`set_primary_images`)
         - reference image (7,8,22) (:py:meth:`set_default_support_images`)
         - null image (1,2,12,13,20) (:py:meth:`set_default_support_images`)
         - comparison image (18) (:py:meth:`set_default_support_images`)
-        - background selection (2,11,13) (TODO)
-        - camera lens characterization (3) (TODO)
-        - image server network address (11) (TODO)
-        - laser color/wavelength (12,13) (TODO)
-        - camera color characterization (12,13) (TODO)
-        - laser placement and pointing angle (16) (TODO)
-        - intensity-to-power mapping (19) (TODO)
+        - background selection (2,11,13) (NOT IMPLEMENTED YET)
+        - camera lens characterization (3) (NOT IMPLEMENTED YET)
+        - image server network address (11) (NOT IMPLEMENTED YET)
+        - laser color/wavelength (12,13) (NOT IMPLEMENTED YET)
+        - camera color characterization (12,13) (NOT IMPLEMENTED YET)
+        - laser placement and pointing angle (16) (NOT IMPLEMENTED YET)
+        - intensity-to-power mapping (19) (NOT IMPLEMENTED YET)
         - multiple primary images, or a primary video (20,24) (:py:meth:`set_primary_images`)
-        - fiducial definition and location (25) (TODO)
-        - manual 3D point identification from 2D images (25) (TODO)
+        - fiducial definition and location (25) (NOT IMPLEMENTED YET)
+        - manual 3D point identification from 2D images (25) (NOT IMPLEMENTED YET)
 
     Example usage::