First iteration of adaptivity hooks #1105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Store DxDp so it can be retrieved * Allow to reset vector spaces at runtime (for adaptation)
* Add new observer that is Tempus-compatible * Call adaptivity hooks in the new observer
* Add dummy adaptation strategy for STK disc and 1d problems * Add new adv-diff test with adaptation
bartgol
commented
Jan 10, 2025
| @@ -389,6 +392,16 @@ class AbstractDiscretization | |||
| const bool overlapped = false, | |||
| const bool force_write_solution = false) = 0; | |||
|
|
|||
| // Check if mesh adaptation is needed, and if so what kind (topological or just mesh-movement) | |||
| virtual Teuchos::RCP<AdaptationData> | |||
There was a problem hiding this comment.
I'm thinking I may change this. Namely, this may just return an AdaptationType enum. The reason is that instead of doing
auto data = disc->checkForAdaptation(x,xdot,xdotdot,dxdp);
if (data->type!=None) {
disc->adapt(data);
}We could just do
auto type = disc->checkForAdaptation(x,xdot,xdotdot,dxdp);
if (type!=None) {
disc->adapt(x,xdot,xdotdot,dxdp);
}without forcing the disc to stuff the OLD x/xdot/xdotdot/dxdp inside the returned type (the caller site already has them anyways).
bartgol
commented
Jan 10, 2025
| @@ -54,6 +54,9 @@ class AbstractMeshFieldAccessor | |||
| virtual void fillSolnMultiVector (Thyra_MultiVector& soln, | |||
| const dof_mgr_ptr_t& sol_dof_mgr, | |||
| const bool overlapped) = 0; | |||
| virtual void fillSolnSensitivity (Thyra_MultiVector& dxdp, | |||
There was a problem hiding this comment.
This, and all the dxdp changes in the PR, are so that we can run a pb that computes sensitivities and do adaptation. I haven't tested the dxdp functionality though, so more work may be needed down the road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a first version of the adaptivity hooks. We may change them later if/when we realize they are insufficient/overkill/wrong/whatever. The goal was to get something working.
Some details: