Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed one major change and a few minor changes #291

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JGreenwald538
Copy link

Purpose

In 2-3 sentences - what does this code actually do, and why?

I fixed an issue I saw on the course descriptions where section tags were included. I also made some minor design changes.

Tickets

What Trello tickets (if any) are associated with this PR?
None

Contributors

Who worked on this PR? Tag them with their Github @username for future reference

Use the "Assignees" feature in Github

@JGreenwald538

Feature List

Expand on the purpose - what does this code do, and how? This should be a list of the changes, more in-depth and technical

  • created a util function that use dom parser to remove HTML tags
  • applied that util function to the section description string
  • Created margin between updated and the icon
  • Changed the back to search results button to just back and made more simple
  • Added more space to the back button
  • Removed all underline from link(different from other links and seemed unnecessary

Pictures

If there are visual changes, show a before/after view, and add a link to the after view using the staging environment.
Before:

After:

https://vercel.com/jgreenwald538s-projects/searchneu/ByazcWYYYbvEkdEtMMjH43gPWika

Reviewers

Primary reviewer:

  • Pick one primary reviewer
    • The team member with the most relevant knowledge about the code area this PR touches
    • NOT an author of the PR
    • If the primary reviewer is the project lead, select two primary reviewers
      • Goal: facilitate knowledge transfer to other team members
    • Primary reviewers are required to approve the PR before it can be merged

Primary:

Use the "Reviewers" feature in Github

Secondary reviewers:

  • Pick as many as appropriate — anyone who would benefit from reading the PR
    • Tag them using their Github usernames below

Secondary:

Copy link

vercel bot commented Nov 20, 2024

@JGreenwald538 is attempting to deploy a commit to the Sandbox NU Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant