-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Onboarding Flow #90
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the shoe fits
apps/web/src/app/_components/onboarding/post-onboarding/welcome-dialog.tsx
Outdated
Show resolved
Hide resolved
heading, | ||
subheading, | ||
buttonText, | ||
onClick, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So would it be crazy to pass a button as a prop rather than text and onClick. Then maybe if we are feeling lazy we can just reuse the new-review-dialog for the meantime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds a user onboarding flow to force the user to create a profile.
Please read this before reviewing:
OnboardingWrapper
componentFor Testing:
/roles
//companies
and confirm that the onboarding flow is initiatedpnpm db:studio
pnpm build
instead ofpnpm dev
since it will take a hot sec for the onboarding flow to appear if you run it in dev mode.Motivation and Context
Closes #88
How has this been tested?
With me eyes (no but fr will add frontend unit and e2e tests after showcase)
Screenshots (if appropriate):
Signed Out User
Signed In User w/ No Profile
Post Onboarding Prompt - Has done a co-op before
Post Onboarding Prompt - Has not done a co-op before
Types of changes
Checklist: