Pr 215 #216
Merged
Pr 215 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new utility script that converts YAML regex files to CommonJS modules. The script recursively processes all YAML files in the regexes directory and generates corresponding .js files with the same structure. This is a preparatory step for removing the filesystem dependency in the main package, making it more suitable for various JavaScript environments.
This commit transforms the regexes detection rules from YAML to CommonJS format as part of the ongoing effort to remove filesystem dependencies. The conversion maintains all existing regex patterns and device detection logic while making the rules more suitable for direct consumption in JavaScript environments.
This commit completes the migration from YAML to CommonJS modules by removing all YAML file loading logic and replacing it with direct requires. The changes include removing the base regex directory path constant, collection map caching, and file loading methods from the abstract parser. All parser classes now directly require their respective CommonJS regex modules instead of loading YAML files at runtime.
feat: update devDependencies and js-yaml move to devDependencies feat: remove helper.loadYMLFile (not uses)
# Conflicts: # parser/helper.js
feat: update devDependencies and js-yaml move to devDependencies feat: remove helper.loadYMLFile (not uses) feat: update generate client indexes feat: remove client-index-hash.yml and device-index-hash.yml (these files are no longer needed, as we use JS files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.