Skip to content

Commit

Permalink
scripts/release: disable minor version docker push
Browse files Browse the repository at this point in the history
Signed-off-by: Gyuho Lee <[email protected]>
  • Loading branch information
gyuho committed May 31, 2018
1 parent aaa71e5 commit 0db7ea7
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions scripts/release
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,11 @@ main() {
gsutil -m cp ./release/*.aci gs://etcd/${RELEASE_VERSION}/
gsutil -m acl ch -u allUsers:R -r gs://etcd/${RELEASE_VERSION}/
fi

# Push images.
if [ "${NO_DOCKER_PUSH}" == 1 ]; then
echo "Skipping docker push. --no-docker-push flat is set."
else
else
read -p "Publish etcd ${RELEASE_VERSION} docker images to quay.io [y/N]? " confirm
[[ "${confirm,,}" == "y" ]] || exit 1
for i in {1..5}; do
Expand All @@ -176,11 +176,11 @@ main() {
fi
gsutil -m acl ch -u allUsers:R -r gs://artifacts.etcd-development.appspot.com

docker tag quay.io/coreos/etcd:${RELEASE_VERSION} quay.io/coreos/etcd:v${MINOR_VERSION}
docker push quay.io/coreos/etcd:v${MINOR_VERSION}

gcloud docker -- tag gcr.io/etcd-development/etcd:${RELEASE_VERSION} gcr.io/etcd-development/etcd:v${MINOR_VERSION}
gcloud docker -- push gcr.io/etcd-development/etcd:v${MINOR_VERSION}
# TODO: upload minor versions: v3.1, v3.2, v3.3, etc.
# docker tag quay.io/coreos/etcd:${RELEASE_VERSION} quay.io/coreos/etcd:v${MINOR_VERSION}
# docker push quay.io/coreos/etcd:v${MINOR_VERSION}
# gcloud docker -- tag gcr.io/etcd-development/etcd:${RELEASE_VERSION} gcr.io/etcd-development/etcd:v${MINOR_VERSION}
# gcloud docker -- push gcr.io/etcd-development/etcd:v${MINOR_VERSION}
fi

# TODO: test
Expand All @@ -204,7 +204,7 @@ main() {
[[ "${confirm,,}" == "y" ]] || exit 1
git push
fi

# TODO: signing process
echo ""
echo "WARNING: The release has not been signed and published to github. This must be done manually."
Expand Down

0 comments on commit 0db7ea7

Please sign in to comment.