Merge pull request #261 from samvera/jul19-ruby-versions

Remove CircleCI ruby/rails version defaults
samvera · Aug 2, 2019 · 583c105 · 583c105
2 parents a1ca767 + f8f5b02
commit 583c105
Showing 1 changed file with 12 additions and 14 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -6,13 +6,11 @@ jobs:
     parameters:
       ruby_version:
         type: string
-        default: 2.6.3
       bundler_version:
         type: string
         default: 1.17.3
       rails_version:
         type: string
-        default: '5.2.3'
     executor:
       name: 'samvera/ruby'
       ruby_version: << parameters.ruby_version >>
@@ -45,25 +43,25 @@ workflows:
     jobs:
       - bundle_and_test:
           name: "ruby2-6_rails5-2"
-          ruby_version: "2.6.3"
-          rails_version: "5.2.3"
+          ruby_version: 2.6.3
+          rails_version: 5.2.3
       - bundle_and_test:
           name: "ruby2-5_rails5-2"
-          ruby_version: "2.5.5"
-          rails_version: "5.2.3"
+          ruby_version: 2.5.5
+          rails_version: 5.2.3
       - bundle_and_test:
           name: "ruby2-4_rails5-2"
-          ruby_version: "2.4.6"
-          rails_version: "5.2.3"
+          ruby_version: 2.4.6
+          rails_version: 5.2.3
       - bundle_and_test:
           name: "ruby2-6_rails5-1"
-          ruby_version: "2.6.3"
-          rails_version: "5.1.7"
+          ruby_version: 2.6.3
+          rails_version: 5.1.7
       - bundle_and_test:
           name: "ruby2-5_rails5-1"
-          ruby_version: "2.5.5"
-          rails_version: "5.1.7"
+          ruby_version: 2.5.5
+          rails_version: 5.1.7
       - bundle_and_test:
           name: "ruby2-4_rails5-1"
-          ruby_version: "2.4.6"
-          rails_version: "5.1.7"
+          ruby_version: 2.4.6
+          rails_version: 5.1.7