-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix contact form submission with negative captcha #2433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: - notch8/palni_palci_knapsack#159 The contact form was failing to process submissions due to conflicts between negative captcha and regular form parameters. This update: - Removes category and contact_method from negative captcha protected fields - Properly merges protected captcha values with regular form parameters - Fixes the "Subject/Category can't be blank" validation error - Ensures all form fields are properly processed while maintaining spam protection This allows the contact form to successfully submit while keeping the negative captcha security measures intact.
Test Results 3 files ±0 3 suites ±0 17m 34s ⏱️ +19s Results for commit bbe0e07. ± Comparison against base commit 644b589. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
kirkkwang
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The contact form was failing to process submissions due to conflicts between negative captcha and regular form parameters. This update:
This allows the contact form to successfully submit while keeping the negative captcha security measures intact.
Screenshots
BEFORE
Screen.Recording.2024-10-09.at.10.11.17.AM.mov
AFTER