Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix contact form submission with negative captcha #2433

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Jan 28, 2025

Issue:

The contact form was failing to process submissions due to conflicts between negative captcha and regular form parameters. This update:

  • Removes category and contact_method from negative captcha protected fields
  • Properly merges protected captcha values with regular form parameters
  • Fixes the "Subject/Category can't be blank" validation error
  • Ensures all form fields are properly processed while maintaining spam protection

This allows the contact form to successfully submit while keeping the negative captcha security measures intact.

Screenshots

BEFORE

Screen.Recording.2024-10-09.at.10.11.17.AM.mov

AFTER

Screenshot 2025-01-28 at 11-12-25 Contact Us

image

image

Issue:
- notch8/palni_palci_knapsack#159

The contact form was failing to process submissions due to conflicts between negative captcha and regular form parameters. This update:

- Removes category and contact_method from negative captcha protected fields
- Properly merges protected captcha values with regular form parameters
- Fixes the "Subject/Category can't be blank" validation error
- Ensures all form fields are properly processed while maintaining spam protection

This allows the contact form to successfully submit while keeping the negative captcha security measures intact.
@ShanaLMoore ShanaLMoore added the minor-ver for release notes label Jan 28, 2025
Copy link

github-actions bot commented Jan 28, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 34s ⏱️ +19s
2 057 tests ±0  2 001 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 084 runs  ±0  2 026 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit bbe0e07. ± Comparison against base commit 644b589.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy b6520ae3-5eb2-4a21-b416-d7f4b3775194
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 563732f3-ec4a-40a1-9e5b-782e7319f77c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 9f4c9f2a-c5dd-43f0-84c3-096aa5362a9b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update e9aac28d-4e6f-4e41-ba57-50d326b8caea
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 8f2a2b1a-6e75-42d2-8835-d54835fb9d64
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit a8d34c04-e07c-4f20-97e7-ea1d20bb1893
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 8f7ae13a-2011-49e0-b4f1-c5ab0afadbfb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update eca0933e-d44f-4e28-9402-efad74819364
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 8bccf12d-41e7-49b2-99bd-d336b7b063dd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 17d96fc3-583a-4a1c-9bf6-1b8e207f1d20
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy b9bcc098-e55b-49db-817c-1f60c9d84371
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 5d62b7c5-0012-4e76-9bb3-30b6a6ae51f2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 8dfbf29d-d423-4fd7-87b5-2f7bc00115ff
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 22b6f924-8a9f-4dd8-8755-fa96b7cdc788
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 281ec951-a2cd-462d-b034-45bca65b3240
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit ce09ec0e-9716-4beb-9c91-c55e4e4a99c9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 71ceae6a-90d7-4e87-9b60-a42027763143
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 6ccb08b7-fc1f-43e7-a606-a75654e84dff
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 3bb7641d-28de-4e4c-9ec7-b16f016c5e7f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 01442346-a1ac-4074-882a-6ec4a77890dd
…

♻️ This comment has been updated with latest results.

@ShanaLMoore ShanaLMoore marked this pull request as ready for review January 28, 2025 21:55
@ShanaLMoore ShanaLMoore merged commit 0777b32 into main Jan 28, 2025
8 of 9 checks passed
@ShanaLMoore ShanaLMoore deleted the i159-unable-to-subject-contact-form branch January 28, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants