Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working on issues with bulkrax and hyrax javascript #2414

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

orangewolf
Copy link
Member

when bulkrax fix gets merged this pr needs to be updated

Copy link

github-actions bot commented Jan 15, 2025

Test Results

    3 files  +    2      3 suites  +2   17m 41s ⏱️ + 13m 19s
2 055 tests +1 377  1 999 ✅ +1 343  56 💤 +34  0 ❌ ±0 
2 082 runs  +1 396  2 024 ✅ +1 360  58 💤 +36  0 ❌ ±0 

Results for commit 64b60d1. ± Comparison against base commit d1c5331.

This pull request removes 2 and adds 1379 tests. Note that renamed tests count towards both.
spec.models.nil_site_spec ‑ NilSite#instance is expected to equal #<NilSite:0x00007f8e6aee0200>
spec.models.nil_site_spec ‑ NilSite#reload is expected to equal #<NilSite:0x00007f8e6aee0200>
spec.abilities.solr_document_ability_spec ‑ Hyrax::Ability::SolrDocumentAbility with Collection solr doc when a user has a Collections Editor role allows most abilities
spec.abilities.solr_document_ability_spec ‑ Hyrax::Ability::SolrDocumentAbility with Collection solr doc when a user has a Collections Editor role denies destroy ability
spec.abilities.solr_document_ability_spec ‑ Hyrax::Ability::SolrDocumentAbility with Collection solr doc when a user has a Collections Manager role allows all abilities
spec.abilities.solr_document_ability_spec ‑ Hyrax::Ability::SolrDocumentAbility with Collection solr doc when a user has a Collections Reader role allows read abilities
spec.abilities.solr_document_ability_spec ‑ Hyrax::Ability::SolrDocumentAbility with Collection solr doc when a user has a Collections Reader role denies most abilities
spec.abilities.solr_document_ability_spec ‑ Hyrax::Ability::SolrDocumentAbility with Collection solr doc when admin user allows all abilities
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 9ccb6a12-c3f6-42eb-9408-2522e722e6ed
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy Etd instance
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy Etd solr doc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit Etd instance
…

♻️ This comment has been updated with latest results.

@ShanaLMoore ShanaLMoore added the ignore-for-release ignore this for release notes label Jan 15, 2025
@ShanaLMoore ShanaLMoore merged commit be514fc into main Jan 15, 2025
8 of 9 checks passed
@ShanaLMoore ShanaLMoore deleted the javascript_issues branch January 15, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release ignore this for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants