Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Fix flaky work_show_presenter_spec #2410

Merged
merged 1 commit into from
Jan 14, 2025
Merged

✅ Fix flaky work_show_presenter_spec #2410

merged 1 commit into from
Jan 14, 2025

Conversation

kirkkwang
Copy link
Collaborator

@kirkkwang kirkkwang commented Jan 14, 2025

This commit will ensure that the state of the test_strategy tenant is returned to its default after the test runs because we were seeing this interfere with other tests it was left set on non-default.

@kirkkwang kirkkwang added the patch-ver for release notes label Jan 14, 2025
Copy link

github-actions bot commented Jan 14, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 31s ⏱️ -26s
2 055 tests ±0  1 999 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 082 runs  ±0  2 024 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 4eb1f53. ± Comparison against base commit 71dfcb5.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy a6f5949f-cbf1-4fe5-8fe5-00c60a7510f6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit aa3c4e56-2608-4581-b551-2794e97a4f35
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read b4eea761-87a5-43bb-bec8-68fe792136e3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 819dea1f-2582-4164-86aa-464182c89dd2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy ab1e1b99-d3d1-4448-8d4d-8af99d1acae0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 940fe4cc-215c-4351-acf8-aa1328706b53
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read eda4c34c-34e3-4be7-833c-e3ce324c492f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update d8100201-c0f2-4d19-820f-9e086f2ab0dc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy c73889f6-46ee-4c4a-b935-dc637dbd21f8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit b6114df1-423b-4c63-954e-fa4692eb368a
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy f34b2278-ba69-4282-afe6-b0f2694fef56
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 68f3bae4-f0cc-49d0-9f1c-411b6530533d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 22984d1e-8061-4cae-ba95-06df13dc5834
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 281a6d8a-b888-4dff-9d87-5a8bb3bb5ceb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 5ec9d4af-8d40-48be-a998-d3075f0629fb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 7092a8f8-8713-45a7-ab77-03d9d565a80a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 35ca88b7-6ed1-4118-91e8-b66928e2c3ba
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 74460276-7f00-412e-ba17-57d06ed2c422
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 8b546977-8464-408b-8723-cf4d5982ff86
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 815eb51c-e111-48b1-9d09-cd82e4193056
…

♻️ This comment has been updated with latest results.

This commit will ensure that the state of the test_strategy tenant is
returned to its default after the test runs because we were seeing this
interfere with other tests it was left set on non-default.
@ShanaLMoore
Copy link
Collaborator

Thanks for digging into this!

@kirkkwang kirkkwang merged commit 8cd869c into main Jan 14, 2025
8 checks passed
@kirkkwang kirkkwang deleted the flaky-spec-fix branch January 14, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants