Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations component #757

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Annotations component #757

merged 5 commits into from
Dec 23, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Dec 19, 2024

Related issues: #649, update scope of #433

Multiple annotation layers with multiple select from https://tanyaclement.github.io/znh_jacksonville_1939/s1576-t86-244/manifest.json:

Screen.Recording.2024-12-20.at.10.26.39.AM.mov

Annotations with multiple tags from https://avannotate.github.io/SuspenseTheLonelyVilla/manifests/manifest.json:

Screenshot 2024-12-20 at 10 24 13 AM

Displays both range and single time-point annotations from https://tanyaclement.github.io/znh_jacksonville_1939/s1576-t86-244/manifest.json:

Screenshot 2024-12-20 at 10 33 07 AM

@Dananji Dananji marked this pull request as ready for review December 20, 2024 15:33
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great as far as I can tell! None of my comments are blockers so feel free to address them as you see fit and merge.

demo/app.js Outdated Show resolved Hide resolved
src/services/annotations-parser.js Show resolved Hide resolved
src/components/MarkersDisplay/MarkersDisplay.md Outdated Show resolved Hide resolved
@Dananji Dananji merged commit 86ef601 into main Dec 23, 2024
2 checks passed
@Dananji Dananji deleted the annotations-component branch December 23, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants