-
Notifications
You must be signed in to change notification settings - Fork 174
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Our GitHub Action should ignore diff/*.pdf errors
Due to unchanged nearby tables and other reasons, latexdiff will sometimes spuriously fail. CI should succeed nonetheless and just omit the diff PDF. This is why we use `make -k`, but it does not affect make's exit status. Extend run.sh so that it can ignore exit statuses. We could have just used `make -i` or arranged to use `-latexdiff-vc` in the recipe, but doing this in run.sh allows us to separate the two `make` commands so they are tidily interleaved with their output in the logs. (Somewhat unfortunately because action arguments can't be lists of strings this increases the coupling between pr-pdfs.yaml and action.yaml.)
- Loading branch information
Showing
3 changed files
with
16 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters